test: Add logger to test_helper in some Rails-related libraries #1345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For action_mailer, action_pack, action_view, delayed_job, and rails
the tests started failing with an uninitialized constant error:
/opt/hostedtoolcache/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/
activesupport-6.1.7.10/lib/active_support/logger_thread_safe_level.rb
:16:in `<module:LoggerThreadSafeLevel>': uninitialized constant
ActiveSupport::LoggerThreadSafeLevel::Logger (NameError)
Logger::Severity.constants.each do |severity|
^^^^^^
Adding the logger library explicitly to the Appraisal resolves the
error.
Co-authored-by: Ariel Valentin <[email protected]>
kaylareopelle
changed the title
kaylareopelle
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
arielvalentin
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For action_mailer, action_pack, action_view, delayed_job, and rails instrumentation the tests are failing on Rails 6.1 and 7.0 with an uninitialized constant error:
Requiring the logger in the test_helper resolves the error.
Relates to #1343